Fixes #1036 #1151
Closed
Fixes #1036 #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-downing
changed the title
asottile
reviewed
Apr 19, 2025
Member
asottile
left a comment
asottile
left a comment
There was a problem hiding this comment.
took a different approach in #1158 which doesn't need to query the actual default branch
also in the future please use a more useful commit message and PR title -- it's super unclear what you're actually changing or improving given the title of this PR
|
|
||
|
|
||
| def get_default_branch(): | ||
| ret = subprocess.getoutput('git config init.defaultBranch').strip() |
Member
There was a problem hiding this comment.
subprocess.getoutput should really never be used -- it invokes a shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1036 where tests fail with default-branch main